michaelh/zephyr
1
0
Fork 0
Code Releases Activity

ieee802154: kw41z: keep global transceiver interrupt unmasked

Browse source 
There is no need to unmask/mask the global transceiver interrupt
in kw41z_start/stop as the radio interrupt line is enabled/disabled
anyway with irq_enable/disable calls.

Signed-off-by: Bogdan Davidoaia <bogdan.davidoaia@linaro.org>
This commit is contained in:
Bogdan Davidoaia 2017-05-02 16:56:09 +03:00 • committed by Anas Nashif
commit 15e55e1823
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/ieee802154/ieee802154_kw41z.c
View file

@ -254,7 +254,6 @@ static int kw41z_set_txpower(struct device *dev, int16_t dbm)
static int kw41z_start(struct device *dev) static int kw41z_start(struct device *dev)
{ {
ZLL->PHY_CTRL &= ~ZLL_PHY_CTRL_TRCV_MSK_MASK;
irq_enable(Radio_1_IRQn); irq_enable(Radio_1_IRQn);
kw41z_set_seq_state(KW41Z_STATE_RX); kw41z_set_seq_state(KW41Z_STATE_RX);
@ -266,7 +265,6 @@ static int kw41z_start(struct device *dev)
static int kw41z_stop(struct device *dev) static int kw41z_stop(struct device *dev)
{ {
irq_disable(Radio_1_IRQn); irq_disable(Radio_1_IRQn);
ZLL->PHY_CTRL |= ZLL_PHY_CTRL_TRCV_MSK_MASK;
kw41z_disable_seq_irq(); kw41z_disable_seq_irq();
kw41z_set_seq_state(KW41Z_STATE_IDLE); kw41z_set_seq_state(KW41Z_STATE_IDLE);
@ -526,8 +524,7 @@ static int kw41z_init(struct device *dev)
ZLL_PHY_CTRL_CCAMSK_MASK | ZLL_PHY_CTRL_CCAMSK_MASK |
ZLL_PHY_CTRL_RXMSK_MASK | ZLL_PHY_CTRL_RXMSK_MASK |
ZLL_PHY_CTRL_TXMSK_MASK | ZLL_PHY_CTRL_TXMSK_MASK |
ZLL_PHY_CTRL_SEQMSK_MASK | ZLL_PHY_CTRL_SEQMSK_MASK;
ZLL_PHY_CTRL_TRCV_MSK_MASK;
#if KW41Z_AUTOACK_ENABLED #if KW41Z_AUTOACK_ENABLED
ZLL->PHY_CTRL |= ZLL_PHY_CTRL_AUTOACK_MASK; ZLL->PHY_CTRL |= ZLL_PHY_CTRL_AUTOACK_MASK;
#endif #endif
@ -593,6 +590,9 @@ static int kw41z_init(struct device *dev)
/* Set default channel to 2405 MHZ */ /* Set default channel to 2405 MHZ */
kw41z_set_channel(dev, KW41Z_DEFAULT_CHANNEL); kw41z_set_channel(dev, KW41Z_DEFAULT_CHANNEL);
/* Unmask Transceiver Global Interrupts */
ZLL->PHY_CTRL &= ~ZLL_PHY_CTRL_TRCV_MSK_MASK;
/* Configre Radio IRQ */ /* Configre Radio IRQ */
NVIC_ClearPendingIRQ(Radio_1_IRQn); NVIC_ClearPendingIRQ(Radio_1_IRQn);
IRQ_CONNECT(Radio_1_IRQn, RADIO_0_IRQ_PRIO, kw41z_isr, 0, 0); IRQ_CONNECT(Radio_1_IRQn, RADIO_0_IRQ_PRIO, kw41z_isr, 0, 0);