michaelh/zephyr
1
0
Fork 0
Code Releases Activity

smbus: Refactor callbacks API

Browse source 
The callbacks API was similar to gpio / espi callbacks API. Refactor
it to use more intuitive names for set / remove callbacks.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
This commit is contained in:
Andrei Emeltchenko 2022-11-04 18:03:32 +02:00 • committed by Anas Nashif
commit 14923f4131
6 changed files with 180 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

44
drivers/smbus/intel_pch_smbus.c
View file

@ -148,26 +148,44 @@ static void smbalert_work(struct k_work *work)
} while (true);
}
static int pch_smbus_manage_smbalert_cb(const struct device *dev,
struct smbus_callback *cb,
bool set)
static int pch_smbus_smbalert_set_sb(const struct device *dev,
struct smbus_callback *cb)
{
struct pch_data *data = dev->data;
LOG_DBG("dev %p cb %p set %d", dev, cb, set);
LOG_DBG("dev %p cb %p", dev, cb);
return smbus_manage_smbus_callback(&data->smbalert_cbs, cb, set);
return smbus_callback_set(&data->smbalert_cbs, cb);
}
static int pch_smbus_manage_host_notify_cb(const struct device *dev,
struct smbus_callback *cb,
bool set)
static int pch_smbus_smbalert_remove_sb(const struct device *dev,
struct smbus_callback *cb)
{
struct pch_data *data = dev->data;
LOG_DBG("dev %p cb %p set %d", dev, cb, set);
LOG_DBG("dev %p cb %p", dev, cb);
return smbus_manage_smbus_callback(&data->host_notify_cbs, cb, set);
return smbus_callback_remove(&data->smbalert_cbs, cb);
}
static int pch_smbus_host_notify_set_cb(const struct device *dev,
struct smbus_callback *cb)
{
struct pch_data *data = dev->data;
LOG_DBG("dev %p cb %p", dev, cb);
return smbus_callback_set(&data->host_notify_cbs, cb);
}
static int pch_smbus_host_notify_remove_cb(const struct device *dev,
struct smbus_callback *cb)
{
struct pch_data *data = dev->data;
LOG_DBG("dev %p cb %p", dev, cb);
return smbus_callback_remove(&data->host_notify_cbs, cb);
}
static int pch_configure(const struct device *dev, uint32_t config)
@ -902,8 +920,10 @@ static const struct smbus_driver_api funcs = {
.smbus_block_write = pch_smbus_block_write,
.smbus_block_read = pch_smbus_block_read,
.smbus_block_pcall = pch_smbus_block_pcall,
.smbus_manage_smbalert_cb = pch_smbus_manage_smbalert_cb,
.smbus_manage_host_notify_cb = pch_smbus_manage_host_notify_cb,
.smbus_smbalert_set_cb = pch_smbus_smbalert_set_sb,
.smbus_smbalert_remove_cb = pch_smbus_smbalert_remove_sb,
.smbus_host_notify_set_cb = pch_smbus_host_notify_set_cb,
.smbus_host_notify_remove_cb = pch_smbus_host_notify_remove_cb,
};
static void smbus_isr(const struct device *dev)

36
drivers/smbus/smbus_handlers.c
View file

@ -144,22 +144,38 @@ static inline int z_vrfy_smbus_block_pcall(const struct device *dev,
}
#include <syscalls/smbus_block_pcall_mrsh.c>
static inline int z_vrfy_smbus_manage_smbalert_cb(const struct device *dev,
struct smbus_callback *cb,
bool set)
static inline int z_vrfy_smbus_smbalert_set_cb(const struct device *dev,
struct smbus_callback *cb)
{
Z_OOPS(Z_SYSCALL_OBJ(dev, K_OBJ_DRIVER_SMBUS));
return z_impl_smbus_manage_smbalert_cb(dev, cb, set);
return z_impl_smbus_smbalert_set_cb(dev, cb);
}
#include <syscalls/smbus_manage_smbalert_cb_mrsh.c>
#include <syscalls/smbus_smbalert_set_cb_mrsh.c>
static inline int z_vrfy_smbus_manage_host_notify_cb(const struct device *dev,
struct smbus_callback *cb,
bool set)
static inline int z_vrfy_smbus_smbalert_remove_cb(const struct device *dev,
struct smbus_callback *cb)
{
Z_OOPS(Z_SYSCALL_OBJ(dev, K_OBJ_DRIVER_SMBUS));
return z_impl_smbus_manage_host_notify_cb(dev, cb, set);
return z_impl_smbus_smbalert_remove_cb(dev, cb);
}
#include <syscalls/smbus_manage_host_notify_cb_mrsh.c>
#include <syscalls/smbus_smbalert_remove_cb_mrsh.c>
static inline int z_vrfy_smbus_host_notify_set_cb(const struct device *dev,
struct smbus_callback *cb)
{
Z_OOPS(Z_SYSCALL_OBJ(dev, K_OBJ_DRIVER_SMBUS));
return z_impl_smbus_host_notify_set_cb(dev, cb);
}
#include <syscalls/smbus_host_notify_set_cb_mrsh.c>
static inline int z_vrfy_smbus_host_notify_remove_cb(const struct device *dev,
struct smbus_callback *cb)
{
Z_OOPS(Z_SYSCALL_OBJ(dev, K_OBJ_DRIVER_SMBUS));
return z_impl_smbus_host_notify_remove_cb(dev, cb);
}
#include <syscalls/smbus_host_notify_remove_cb_mrsh.c>