From 148a6e2ee1dcfbc7557ab59f9dba8935f8d75ee5 Mon Sep 17 00:00:00 2001 From: Anas Nashif Date: Sat, 5 Nov 2022 13:20:19 -0400 Subject: [PATCH] twister: do not recorde a null version In some scenarios we might end up with a null version value in the json file, if the version can't be determined, set it to Unkown instead. Signed-off-by: Anas Nashif --- scripts/pylib/twister/twisterlib/environment.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/pylib/twister/twisterlib/environment.py b/scripts/pylib/twister/twisterlib/environment.py index bc739b0ff64..5e2b3a24a5a 100644 --- a/scripts/pylib/twister/twisterlib/environment.py +++ b/scripts/pylib/twister/twisterlib/environment.py @@ -698,8 +698,13 @@ class TwisterEnv: universal_newlines=True, cwd=ZEPHYR_BASE) if subproc.returncode == 0: - self.version = subproc.stdout.strip() - logger.info(f"Zephyr version: {self.version}") + _version = subproc.stdout.strip() + if _version: + self.version = _version + logger.info(f"Zephyr version: {self.version}") + else: + self.version = "Unknown" + logger.error("Coult not determine version") except OSError: logger.info("Cannot read zephyr version.")