From 13c74a0764fa8feecf3f1d3343c956c780e76357 Mon Sep 17 00:00:00 2001 From: Pisit Sawangvonganan Date: Sat, 23 Nov 2024 13:18:23 +0700 Subject: [PATCH] modbus: serial: remove redundant `cfg->dev` usage in `uart_cb_handler` Simplify `uart_cb_handler` by directly using `dev` instead of `cfg->dev`, as both hold the same value. Signed-off-by: Pisit Sawangvonganan --- subsys/modbus/modbus_serial.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/subsys/modbus/modbus_serial.c b/subsys/modbus/modbus_serial.c index b35a4bb35bc..05ab70563ee 100644 --- a/subsys/modbus/modbus_serial.c +++ b/subsys/modbus/modbus_serial.c @@ -386,22 +386,19 @@ static void cb_handler_tx(struct modbus_context *ctx) static void uart_cb_handler(const struct device *dev, void *app_data) { struct modbus_context *ctx = (struct modbus_context *)app_data; - struct modbus_serial_config *cfg; if (ctx == NULL) { LOG_ERR("Modbus hardware is not properly initialized"); return; } - cfg = ctx->cfg; + if (uart_irq_update(dev) && uart_irq_is_pending(dev)) { - if (uart_irq_update(cfg->dev) && uart_irq_is_pending(cfg->dev)) { - - if (uart_irq_rx_ready(cfg->dev)) { + if (uart_irq_rx_ready(dev)) { cb_handler_rx(ctx); } - if (uart_irq_tx_ready(cfg->dev)) { + if (uart_irq_tx_ready(dev)) { cb_handler_tx(ctx); } }