michaelh/zephyr
1
0
Fork 0
Code Releases Activity

coding guidelines 10.4: casting operands to have same types

Browse source 
File zephyr/lib/os/cbprintf_nano.c had operands with different types.
It caused Rule 10.4 violation.
Both operands of an operator in which the usual arithmetic conversions
are performed shall have the same essential type category.

Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>

coding guidelines 10.4: casting operands to have same types

File zephyr/lib/os/cbprintf_nano.c had operands with different types.
It caused Rule 10.4 violation.
Both operands of an operator in which the usual arithmetic conversions
are performed shall have the same essential type category.

Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>

removed cast to int
This commit is contained in:
Maksim Masalski 2021-04-30 17:45:20 +08:00 • committed by Carles Cufí
commit 136c9424c5
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/os/cbprintf_nano.c
View file

@ -77,7 +77,7 @@ int cbvprintf(cbprintf_cb out, void *ctx, const char *fmt, va_list ap)
start:
while (*++fmt != '%') {
if (*fmt == 0) {
if (*fmt == '\0') {
return count;
}
OUTC(*fmt);
@ -105,7 +105,7 @@ start:
case '.':
precision = 0;
padding_mode &= ~PAD_ZERO;
padding_mode &= (char)~PAD_ZERO;
continue;
case '0':
@ -159,7 +159,7 @@ start:
length_mod = 'H';
} else if (*fmt == 'l' && length_mod == 'l') {
length_mod = 'L';
} else if (length_mod == 0) {
} else if (length_mod == '\0') {
length_mod = *fmt;
} else {
OUTC('%');
@ -219,7 +219,7 @@ start:
if (*fmt == 'p') {
x = (uintptr_t)va_arg(ap, void *);
if (x == 0) {
if (x == (uint_value_type)0) {
data = "(nil)";
data_len = 5;
precision = 0;