michaelh/zephyr
1
0
Fork 0
Code Releases Activity

scripts: Remove unused variables in all Python scripts

Browse source 
Discovered with pylint3.

Use the placeholder name '_' for unproblematic unused variables. It's
what I'm used to, and pylint knows not to flag it.

Python tip:

    for i in range(n):
        some_list.append(0)

can be replaced with

    some_list += n*[0]

Similarly, 3*'\t' gives '\t\t\t'.

(Relevant here because pylint flagged the loop index as unused.)

To do integer division in Python 3, use // instead of /.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-03-19 19:28:24 +01:00 • committed by Kumar Gala
commit 12ba9dfa52
15 changed files with 19 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/gen_relocate_app.py
View file

@ -292,7 +292,7 @@ def get_obj_filename(searchpath, filename):
# get the object file name which is almost always pended with .obj
obj_filename = filename.split("/")[-1] + ".obj"
for dirpath, dirs, files in os.walk(searchpath):
for dirpath, _, files in os.walk(searchpath):
for filename1 in files:
if filename1 == obj_filename:
if filename.split("/")[-2] in dirpath.split("/")[-1]: