michaelh/zephyr
1
0
Fork 0
Code Releases Activity

logging: fix LOG_TAG_MAX_LEN min warning

Browse source 
if CONFIG_LOG_TAG_MAX_LEN is 0, then a warning would be generated
on the MIN macro always being false, but as
CONFIG_LOG_TAG_MAX_LEN is a constant, then it is better to just
compile out the function if it's 0.

Signed-off-by: Ryan McClelland <ryanmcclelland@fb.com>
This commit is contained in:
Ryan McClelland 2022-04-15 14:08:03 -07:00 • committed by Carles Cufí
commit 1216f19a89
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
subsys/logging/log_core.c
View file

@ -1271,10 +1271,7 @@ const char *z_log_get_tag(void)
int log_set_tag(const char *str) int log_set_tag(const char *str)
{ {
if (CONFIG_LOG_TAG_MAX_LEN == 0) { #if CONFIG_LOG_TAG_MAX_LEN > 0
return -ENOTSUP;
}
if (str == NULL) { if (str == NULL) {
return -EINVAL; return -EINVAL;
} }
@ -1291,6 +1288,9 @@ int log_set_tag(const char *str)
} }
return 0; return 0;
#else
return -ENOTSUP;
#endif
} }
int log_mem_get_usage(uint32_t *buf_size, uint32_t *usage) int log_mem_get_usage(uint32_t *buf_size, uint32_t *usage)