michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: mgmt: mcumgr: Disable clang warning

Browse source 
When building with clang it reports:

tests/subsys/mgmt/mcumgr/settings_mgmt/src/main.c:69:22: error: variable
'test_response_read_data_start' is not needed and will not be emitted
[-Werror,-Wunneeded-internal-declaration]
static const uint8_t test_response_read_data_start[5] = {
                     ^
tests/subsys/mgmt/mcumgr/settings_mgmt/src/main.c:73:22: error: variable
'test_response_read_data_end' is not needed and will not be emitted
[-Werror,-Wunneeded-internal-declaration]
static const uint8_t test_response_read_data_end[1] = {
                     ^

The values of test_response_read_data_start and
test_response_read_data_end are not actually used anywhere in the tests.

Signed-off-by: Tom Hughes <tomhughes@chromium.org>
This commit is contained in:
Tom Hughes 2025-01-10 15:18:11 -08:00 • committed by Benjamin Cabé
commit 11e3aa8952
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
include/zephyr/toolchain/llvm.h
View file

@ -30,7 +30,8 @@
#include <zephyr/toolchain/gcc.h> #include <zephyr/toolchain/gcc.h>
#define TOOLCHAIN_WARNING_SIZEOF_ARRAY_DECAY "-Wsizeof-array-decay" #define TOOLCHAIN_WARNING_SIZEOF_ARRAY_DECAY "-Wsizeof-array-decay"
#define TOOLCHAIN_WARNING_UNNEEDED_INTERNAL_DECLARATION "-Wunneeded-internal-declaration"
#define TOOLCHAIN_DISABLE_CLANG_WARNING(warning) _TOOLCHAIN_DISABLE_WARNING(clang, warning) #define TOOLCHAIN_DISABLE_CLANG_WARNING(warning) _TOOLCHAIN_DISABLE_WARNING(clang, warning)
#define TOOLCHAIN_ENABLE_CLANG_WARNING(warning) _TOOLCHAIN_ENABLE_WARNING(clang, warning) #define TOOLCHAIN_ENABLE_CLANG_WARNING(warning) _TOOLCHAIN_ENABLE_WARNING(clang, warning)

7
tests/subsys/mgmt/mcumgr/settings_mgmt/src/main.c
View file

@ -66,6 +66,12 @@ static const uint8_t test_response_error_data[8] = {
0xbf, 0x62, 0x72, 0x63, 0x19, 0x01, 0x00, 0xff 0xbf, 0x62, 0x72, 0x63, 0x19, 0x01, 0x00, 0xff
}; };
/*
* TODO: The contents of these structs are not used, which is why clang complains.
* The test should be updated to use these values. See discussion in
* https://github.com/zephyrproject-rtos/zephyr/pull/87592.
*/
TOOLCHAIN_DISABLE_CLANG_WARNING(TOOLCHAIN_WARNING_UNNEEDED_INTERNAL_DECLARATION)
static const uint8_t test_response_read_data_start[5] = { static const uint8_t test_response_read_data_start[5] = {
0xbf, 0x63, 0x76, 0x61, 0x6c 0xbf, 0x63, 0x76, 0x61, 0x6c
}; };
@ -73,6 +79,7 @@ static const uint8_t test_response_read_data_start[5] = {
static const uint8_t test_response_read_data_end[1] = { static const uint8_t test_response_read_data_end[1] = {
0xff 0xff
}; };
TOOLCHAIN_ENABLE_CLANG_WARNING(TOOLCHAIN_WARNING_UNNEEDED_INTERNAL_DECLARATION)
static void cleanup_test(void *p) static void cleanup_test(void *p)
{ {