michaelh/zephyr
1
0
Fork 0
Code Releases Activity

lib: os: hex: clarify controlling expression

Browse source 
add explicit boolean type to 'if' statement controlling expression, thus
improving code readability and maintainability, complying with required
[misra-c2012-14.4] rule which states; The controlling expression of an
if statement and the controlling expression of an iteration-statement
shall have essentially boolean type.

Found as a coding guideline violation (Rule 14.4) by static code
scanning tool.

Note: Tested on STM32L5 Nucleo-144 board (stm32l552xx).

Signed-off-by: ferar alashkar <ferar.alashkar@gmail.com>
This commit is contained in:
ferar alashkar 2023-06-17 18:02:34 -04:00 • committed by Fabio Baltieri
commit 11e2c58928
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/os/hex.c
View file

@ -65,7 +65,7 @@ size_t hex2bin(const char *hex, size_t hexlen, uint8_t *buf, size_t buflen)
} }
/* if hexlen is uneven, insert leading zero nibble */ /* if hexlen is uneven, insert leading zero nibble */
if (hexlen % 2U) { if ((hexlen % 2U) != 0) {
if (char2hex(hex[0], &dec) < 0) { if (char2hex(hex[0], &dec) < 0) {
return 0; return 0;
} }