michaelh/zephyr
1
0
Fork 0
Code Releases Activity

scripts: gen_relocate_app.py: Simplify test with 'in'

Browse source 
Getting slightly subjective, but fixes this pylint warning:

    scripts/gen_relocate_app.py:228:38: R1714: Consider merging these
    comparisons with "in" to "region in ('data', 'bss')"
    (consider-using-in)

Use a set literal instead of a tuple literal, as recent Python 3
versions optimize set literals with constant keys nicely.

Getting rid of pylint warnings for a CI check. I could disable any
controversial ones (it's already a list of warnings to enable anyway).

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-09-03 14:29:31 +02:00 • committed by Anas Nashif
commit 11d98ae9de
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/gen_relocate_app.py
View file

@ -225,7 +225,7 @@ def string_create_helper(region, memory_type,
# Create a complete list of funcs/ variables that goes in for this # Create a complete list of funcs/ variables that goes in for this
# memory type # memory type
tmp = print_linker_sections(full_list_of_sections[region]) tmp = print_linker_sections(full_list_of_sections[region])
if memory_type == 'SRAM' and (region == 'data' or region == 'bss'): if memory_type == 'SRAM' and region in {'data', 'bss'}:
linker_string += tmp linker_string += tmp
else: else:
if memory_type != 'SRAM' and region == 'rodata': if memory_type != 'SRAM' and region == 'rodata':