From 110d58c055c84aa75442f1525d89829c827d2445 Mon Sep 17 00:00:00 2001 From: Sharron LIU Date: Sun, 22 Jan 2017 15:38:56 +0800 Subject: [PATCH] tests: kernel: mbox_api: fix uninit variable and unchecked value "struct k_mbox_msg mmsg" should be initialized before using. "int" value returned by k_mem_pool_alloc() should be checked. Coverity-CID: 160083 Coverity-CID: 160470 Change-Id: I35714bf9d76723c5fdd8c2963bf76b42ae1b1867 Signed-off-by: Sharron LIU --- tests/kernel/mbox/mbox_api/src/test_mbox_api.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/kernel/mbox/mbox_api/src/test_mbox_api.c b/tests/kernel/mbox/mbox_api/src/test_mbox_api.c index 207b209c3a0..d6a10098cfe 100644 --- a/tests/kernel/mbox/mbox_api/src/test_mbox_api.c +++ b/tests/kernel/mbox/mbox_api/src/test_mbox_api.c @@ -63,6 +63,8 @@ static void tmbox_put(struct k_mbox *pmbox) { struct k_mbox_msg mmsg; + memset(&mmsg, 0, sizeof(mmsg)); + switch (info_type) { case PUT_GET_NULL: /**TESTPOINT: mbox sync put empty message*/ @@ -104,7 +106,8 @@ static void tmbox_put(struct k_mbox *pmbox) mmsg.info = ASYNC_PUT_GET_BLOCK; mmsg.size = MAIL_LEN; mmsg.tx_data = NULL; - k_mem_pool_alloc(&mpooltx, &mmsg.tx_block, MAIL_LEN, K_NO_WAIT); + assert_equal(k_mem_pool_alloc(&mpooltx, &mmsg.tx_block, + MAIL_LEN, K_NO_WAIT), 0, NULL); memcpy(mmsg.tx_block.data, data[info_type], MAIL_LEN); if (info_type == TARGET_SOURCE_THREAD_BLOCK) { mmsg.tx_target_thread = receiver_tid;