michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: l2: wifi: Fix mode change issue in Wi-Fi shell

Browse source 
The help message for the wifi mode -s command indicates it sets
the Wi-Fi mode to station. However, the Zephyr Wi-Fi shell subsystem
was incorrectly using a get operation instead of set.

This commit corrects the behavior to properly set the Wi-Fi mode,
aligning the implementation with the help message.

Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>
This commit is contained in:
Arunmani Alagarsamy 2025-06-06 12:05:00 +05:30 • committed by Benjamin Cabé
commit 0faba15717
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
subsys/net/l2/wifi/wifi_shell.c
View file

@ -2906,11 +2906,11 @@ void parse_mode_args_to_params(const struct shell *sh, int argc,
{"monitor", no_argument, 0, 'm'}, {"monitor", no_argument, 0, 'm'},
{"ap", no_argument, 0, 'a'}, {"ap", no_argument, 0, 'a'},
{"softap", no_argument, 0, 'k'}, {"softap", no_argument, 0, 'k'},
{"get", no_argument, 0, 'g'},
{"help", no_argument, 0, 'h'}, {"help", no_argument, 0, 'h'},
{0, 0, 0, 0}}; {0, 0, 0, 0}};
while ((opt = getopt_long(argc, argv, "i:smtpakgh", mode->oper = WIFI_MGMT_GET;
while ((opt = getopt_long(argc, argv, "i:smtpakh",
long_options, &opt_index)) != -1) { long_options, &opt_index)) != -1) {
state = getopt_state_get(); state = getopt_state_get();
switch (opt) { switch (opt) {
@ -2930,10 +2930,6 @@ void parse_mode_args_to_params(const struct shell *sh, int argc,
mode->mode |= WIFI_SOFTAP_MODE; mode->mode |= WIFI_SOFTAP_MODE;
opt_num++; opt_num++;
break; break;
case 'g':
mode->oper = WIFI_MGMT_GET;
opt_num++;
break;
case 'i': case 'i':
mode->if_index = (uint8_t)atoi(state->optarg); mode->if_index = (uint8_t)atoi(state->optarg);
/* Don't count iface as it's common for both get and set */ /* Don't count iface as it's common for both get and set */
@ -2949,7 +2945,7 @@ void parse_mode_args_to_params(const struct shell *sh, int argc,
} }
} }
if (opt_num == 0) { if (opt_num != 0) {
mode->oper = WIFI_MGMT_SET; mode->oper = WIFI_MGMT_SET;
} }
} }
@ -4108,9 +4104,8 @@ SHELL_SUBCMD_ADD((wifi), mode, NULL,
"[-a, --ap] : AP mode\n" "[-a, --ap] : AP mode\n"
"[-k, --softap] : Softap mode\n" "[-k, --softap] : Softap mode\n"
"[-h, --help] : Help\n" "[-h, --help] : Help\n"
"[-g, --get] : Get current mode for a specific interface index\n"
"Usage: Get operation example for interface index 1\n" "Usage: Get operation example for interface index 1\n"
"wifi mode -g -i1\n" "wifi mode -i1\n"
"Set operation example for interface index 1 - set station+promiscuous\n" "Set operation example for interface index 1 - set station+promiscuous\n"
"wifi mode -i1 -sp.\n", "wifi mode -i1 -sp.\n",
cmd_wifi_mode, cmd_wifi_mode,