michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests/tinycrypt: Fix dead code issue (2nd)

Browse source 
This commit fixes the dead code issue reported by Coverity.

Coverity-CID: 151977

Change-Id: Iaa31c032456f48e1af1d1c9d722f051ac5519ccf
Signed-off-by: Flavio Santes <flavio.santes@intel.com>
This commit is contained in:
Flavio Santes 2016-11-16 16:26:10 -06:00 • committed by Anas Nashif
commit 0f231c70d3
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/crypto/test_ecc_dsa/src/test_ecc_dsa.c
View file

@ -334,6 +334,8 @@ int verify_vectors(TCSha256State_t hash, char **msg_vec, char **qx_vec,
int rc = TC_FAIL; int rc = TC_FAIL;
for (int i = 0; i < tests; i++) { for (int i = 0; i < tests; i++) {
int hash_dwords;
str_to_scalar(pub.x, NUM_ECC_DIGITS, qx_vec[i]); str_to_scalar(pub.x, NUM_ECC_DIGITS, qx_vec[i]);
str_to_scalar(pub.y, NUM_ECC_DIGITS, qy_vec[i]); str_to_scalar(pub.y, NUM_ECC_DIGITS, qy_vec[i]);
str_to_scalar(r, NUM_ECC_DIGITS, r_vec[i]); str_to_scalar(r, NUM_ECC_DIGITS, r_vec[i]);
@ -358,11 +360,10 @@ int verify_vectors(TCSha256State_t hash, char **msg_vec, char **qx_vec,
/* if digest larger than ECC scalar, drop the end /* if digest larger than ECC scalar, drop the end
* if digest smaller than ECC scalar, zero-pad front * if digest smaller than ECC scalar, zero-pad front
*/ */
int hash_dwords = TC_SHA256_DIGEST_SIZE / 4; /* Note: here it is assumed that:
* NUM_ECC_DIGITS * 4 == TC_SHA256_DIGEST_SIZE
if (hash_dwords > NUM_ECC_DIGITS) { */
hash_dwords = NUM_ECC_DIGITS; hash_dwords = TC_SHA256_DIGEST_SIZE / 4;
}
memset(dig32, 0, NUM_ECC_BYTES - 4 * hash_dwords); memset(dig32, 0, NUM_ECC_BYTES - 4 * hash_dwords);
ecc_bytes2native(dig32 + (NUM_ECC_DIGITS - hash_dwords), ecc_bytes2native(dig32 + (NUM_ECC_DIGITS - hash_dwords),