michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: k_work: k_work_init() should initialize all fields

Browse source 
k_work_init() was not initializing all fields in the k_work struct.

Mainly, the atomic_clear_bit() function call was reading a possibly
uninitialized value, clearing a bit, and assigning it back to the
`flags` member.  The `_reserved` member was never initialized.

With the struct now initialized with the _K_WORK_INITIALIZER() macro,
initialization is consistent regardless of how a `struct k_work` is
initialized.

This fixes the Valgrind issues found in #7478.

Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2018-05-29 10:42:17 -07:00 • committed by Anas Nashif
commit 0e23ad889e
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
include/kernel.h
View file

@ -2584,8 +2584,7 @@ extern struct k_work_q k_sys_work_q;
*/
static inline void k_work_init(struct k_work *work, k_work_handler_t handler)
{
atomic_clear_bit(work->flags, K_WORK_STATE_PENDING);
work->handler = handler;
*work = (struct k_work)_K_WORK_INITIALIZER(handler);
_k_object_init(work);
}