michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: net: icmpv4: Test NULL ptr in proper time

Browse source 
The code tried to use the allocated pkt ptr before checking for
NULL value.

Fixes #21699
Coverity-CID: 206608

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2020-01-07 13:39:20 +02:00
commit 0b7844e0be
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/net/icmpv4/src/main.c
View file

@ -181,10 +181,9 @@ void test_icmpv4(void)
pkt = net_pkt_alloc_with_buffer(NULL, sizeof(icmpv4_echo_req),
AF_UNSPEC, 0, K_SECONDS(1));
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
zassert_not_null(pkt, "Allocation failed");
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
net_pkt_write(pkt, icmpv4_echo_req, sizeof(icmpv4_echo_req));
net_pkt_cursor_init(pkt);
@ -214,10 +213,9 @@ void test_icmpv4(void)
pkt = net_pkt_alloc_with_buffer(NULL, sizeof(icmpv4_echo_rep),
AF_UNSPEC, 0, K_SECONDS(1));
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
zassert_not_null(pkt, "Allocation failed");
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
net_pkt_write(pkt, icmpv4_echo_rep, sizeof(icmpv4_echo_rep));
net_pkt_cursor_init(pkt);
@ -247,10 +245,9 @@ void test_icmpv4(void)
pkt = net_pkt_alloc_with_buffer(NULL, sizeof(icmpv4_echo_req_opt),
AF_UNSPEC, 0, K_SECONDS(1));
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
zassert_not_null(pkt, "Allocation failed");
net_pkt_set_ip_hdr_len(pkt, sizeof(struct net_ipv4_hdr));
net_pkt_write(pkt, icmpv4_echo_req_opt, sizeof(icmpv4_echo_req_opt));
net_pkt_cursor_init(pkt);