michaelh/zephyr
1
0
Fork 0
Code Releases Activity

guideline: Make explicit fallthrough cases

Browse source 
-Wimplicit-fallthrough=2 requires a fallthrough comment or a compiler
to tells gcc that this happens intentionally.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2020-08-21 13:45:52 -07:00 • committed by Anas Nashif
commit 0aaae4a039
46 changed files with 105 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

8
subsys/bluetooth/controller/ll_sw/ull_conn.c
View file

@ -441,7 +441,7 @@ uint32_t ll_length_req_send(uint16_t handle, uint16_t tx_octets, uint16_t tx_tim
#endif /* CONFIG_BT_CTLR_PHY */
return 0;
}
/* pass through */
__fallthrough;
default:
return BT_HCI_ERR_CMD_DISALLOWED;
}
@ -4923,7 +4923,7 @@ static inline void ctrl_tx_pre_ack(struct ll_conn *conn,
if (!conn->lll.role) {
break;
}
/* fallthrough */
__fallthrough;
case PDU_DATA_LLCTRL_TYPE_ENC_REQ:
case PDU_DATA_LLCTRL_TYPE_ENC_RSP:
@ -5027,7 +5027,7 @@ static inline void ctrl_tx_ack(struct ll_conn *conn, struct node_tx **tx,
PDU_DATA_LLCTRL_TYPE_ENC_REQ) {
break;
}
/* Pass through */
__fallthrough;
case PDU_DATA_LLCTRL_TYPE_REJECT_IND:
/* resume data packet rx and tx */
@ -5100,7 +5100,7 @@ static inline void ctrl_tx_ack(struct ll_conn *conn, struct node_tx **tx,
#if defined(CONFIG_BT_CTLR_PHY)
case PDU_DATA_LLCTRL_TYPE_PHY_REQ:
conn->llcp_phy.state = LLCP_PHY_STATE_RSP_WAIT;
/* fall through */
__fallthrough;
case PDU_DATA_LLCTRL_TYPE_PHY_RSP:
if (conn->lll.role) {