michaelh/zephyr
1
0
Fork 0
Code Releases Activity

mgmt: mcumgr: grp: fs_mgmt: Fix wrong error checking

Browse source 
Fixes an issue with not properly checking error responses.

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
This commit is contained in:
Jamie McCrae 2023-07-31 07:48:20 +01:00 • committed by Carles Cufí
commit 097c568c81
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
subsys/mgmt/mcumgr/grp/fs_mgmt/src/fs_mgmt.c
View file

@ -280,9 +280,9 @@ static int fs_mgmt_file_download(struct smp_streamer *ctxt)
rc = fs_open(&fs_mgmt_ctxt.file, path, FS_O_READ);
if (rc != 0) {
if (rc == EINVAL) {
if (rc == -EINVAL) {
rc = FS_MGMT_RET_RC_FILE_INVALID_NAME;
} else if (ENOENT) {
} else if (rc == -ENOENT) {
rc = FS_MGMT_RET_RC_FILE_NOT_FOUND;
} else {
rc = FS_MGMT_RET_RC_UNKNOWN;
@ -422,9 +422,9 @@ static int fs_mgmt_file_upload(struct smp_streamer *ctxt)
rc = fs_open(&fs_mgmt_ctxt.file, file_name, FS_O_CREATE | FS_O_WRITE);
if (rc != 0) {
if (rc == EINVAL) {
if (rc == -EINVAL) {
rc = FS_MGMT_RET_RC_FILE_INVALID_NAME;
} else if (ENOENT) {
} else if (rc == -ENOENT) {
rc = FS_MGMT_RET_RC_FILE_NOT_FOUND;
} else {
rc = FS_MGMT_RET_RC_UNKNOWN;
@ -741,9 +741,9 @@ static int fs_mgmt_file_hash_checksum(struct smp_streamer *ctxt)
rc = fs_open(&file, path, FS_O_READ);
if (rc != 0) {
if (rc == EINVAL) {
if (rc == -EINVAL) {
rc = FS_MGMT_RET_RC_FILE_INVALID_NAME;
} else if (ENOENT) {
} else if (rc == -ENOENT) {
rc = FS_MGMT_RET_RC_FILE_NOT_FOUND;
} else {
rc = FS_MGMT_RET_RC_UNKNOWN;