michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: context: Operations on unused context should lead to EBADF.

Browse source 
Semantics of ENOENT error as used previously is "named entity not
found", whereas for "I/O handle is not valid", there's EBADF. For
example, POSIX/SUSV2 doesn't even list ENOENT as a possible error
for accept(), connect(), recv(), etc. whereas it lists EBADF, e.g.:
http://pubs.opengroup.org/onlinepubs/7908799/xns/connect.html

Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
This commit is contained in:
Paul Sokolovsky 2017-06-04 14:28:04 +03:00 • committed by Jukka Rissanen
commit 08a2c6019c
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
subsys/net/ip/net_context.c
View file

@ -646,7 +646,7 @@ int net_context_listen(struct net_context *context, int backlog)
NET_ASSERT(PART_OF_ARRAY(contexts, context));
if (!net_context_is_used(context)) {
return -ENOENT;
return -EBADF;
}
#if defined(CONFIG_NET_OFFLOAD)
@ -1064,7 +1064,7 @@ int net_context_connect(struct net_context *context,
#endif
if (!net_context_is_used(context)) {
return -ENOENT;
return -EBADF;
}
if (addr->family != net_context_get_family(context)) {
@ -1577,7 +1577,7 @@ int net_context_accept(struct net_context *context,
NET_ASSERT(PART_OF_ARRAY(contexts, context));
if (!net_context_is_used(context)) {
return -ENOENT;
return -EBADF;
}
#if defined(CONFIG_NET_OFFLOAD)
@ -1748,7 +1748,7 @@ static int sendto(struct net_pkt *pkt,
int ret;
if (!net_context_is_used(context)) {
return -ENOENT;
return -EBADF;
}
#if defined(CONFIG_NET_TCP)
@ -2051,7 +2051,7 @@ int net_context_recv(struct net_context *context,
NET_ASSERT(context);
if (!net_context_is_used(context)) {
return -ENOENT;
return -EBADF;
}
#if defined(CONFIG_NET_OFFLOAD)