From 076eee3abc079dbc396e0c0d5d26f35dbe819ba3 Mon Sep 17 00:00:00 2001 From: Daniel Leung Date: Tue, 17 Dec 2019 10:49:29 -0800 Subject: [PATCH] subsys/random: fix unused value warning When using LLVM/Clang, it complains about memcpy() being casted to (void *): warning: expression result unused; should this cast be to 'void'? [-Wunused-value] So change those to (void) instead as the return of memcpy() is not used anyway. Signed-off-by: Daniel Leung --- subsys/random/rand32_entropy_device.c | 2 +- subsys/random/rand32_timer.c | 2 +- subsys/random/rand32_timestamp.c | 2 +- subsys/random/rand32_xoroshiro128.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/subsys/random/rand32_entropy_device.c b/subsys/random/rand32_entropy_device.c index 4c289343cb8..6f846db1ee5 100644 --- a/subsys/random/rand32_entropy_device.c +++ b/subsys/random/rand32_entropy_device.c @@ -80,7 +80,7 @@ static void rand_get(u8_t *dst, size_t outlen) random_num = k_cycle_get_32(); if ((outlen-len) < sizeof(random_num)) { blocksize = len; - (void *)memcpy(&(dst[random_num]), + (void)memcpy(&(dst[random_num]), &random_num, blocksize); } else { *((u32_t *)&dst[len]) = random_num; diff --git a/subsys/random/rand32_timer.c b/subsys/random/rand32_timer.c index 20ba6efec84..8c9207dfae1 100644 --- a/subsys/random/rand32_timer.c +++ b/subsys/random/rand32_timer.c @@ -71,7 +71,7 @@ void sys_rand_get(void *dst, size_t outlen) ret = sys_rand32_get(); if ((outlen-len) < sizeof(ret)) { blocksize = len; - (void *)memcpy(udst, &ret, blocksize); + (void)memcpy(udst, &ret, blocksize); } else { (*udst++) = ret; } diff --git a/subsys/random/rand32_timestamp.c b/subsys/random/rand32_timestamp.c index e26d9583f7e..a51efde7fd7 100644 --- a/subsys/random/rand32_timestamp.c +++ b/subsys/random/rand32_timestamp.c @@ -60,7 +60,7 @@ void sys_rand_get(void *dst, size_t outlen) ret = sys_rand32_get(); if ((outlen-len) < sizeof(ret)) { blocksize = len; - (void *)memcpy(udst, &ret, blocksize); + (void)memcpy(udst, &ret, blocksize); } else { (*udst++) = ret; } diff --git a/subsys/random/rand32_xoroshiro128.c b/subsys/random/rand32_xoroshiro128.c index 610e9cc3e4c..8fc8b6525c2 100644 --- a/subsys/random/rand32_xoroshiro128.c +++ b/subsys/random/rand32_xoroshiro128.c @@ -107,7 +107,7 @@ void sys_rand_get(void *dst, size_t outlen) ret = xoroshiro128_next(); if ((outlen-len) < sizeof(ret)) { blocksize = len; - (void *)memcpy(udst, &ret, blocksize); + (void)memcpy(udst, &ret, blocksize); } else { (*udst++) = ret; }