From 0722e1d89658c88bc82f4bfbb06f4b37e57074d9 Mon Sep 17 00:00:00 2001 From: Robert Lubos Date: Thu, 15 Jul 2021 15:25:21 +0200 Subject: [PATCH] net: lwm2m: Prevent notifications on non-readable resources In case a non-readable resource gets updated (either by the server or with an API), it makes no sense to send a notification in such case, as no such resources are not included in notifications anyway. Signed-off-by: Robert Lubos --- subsys/net/lib/lwm2m/lwm2m_engine.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/subsys/net/lib/lwm2m/lwm2m_engine.c b/subsys/net/lib/lwm2m/lwm2m_engine.c index df54ee600c3..ae02836ea8b 100644 --- a/subsys/net/lib/lwm2m/lwm2m_engine.c +++ b/subsys/net/lib/lwm2m/lwm2m_engine.c @@ -1675,7 +1675,7 @@ static int lwm2m_engine_set(char *pathstr, void *value, uint16_t len) data_ptr, len, false, 0); } - if (changed) { + if (changed && LWM2M_HAS_PERM(obj_field, LWM2M_PERM_R)) { NOTIFY_OBSERVER_PATH(&path); } @@ -2748,7 +2748,9 @@ int lwm2m_write_handler(struct lwm2m_engine_obj_inst *obj_inst, res_inst->data_len = len; - NOTIFY_OBSERVER_PATH(&msg->path); + if (LWM2M_HAS_PERM(obj_field, LWM2M_PERM_R)) { + NOTIFY_OBSERVER_PATH(&msg->path); + } return ret; }