michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: mcux_gpt_timer: Fix rounding error on tick boundary

Browse source 
GPT timer driver was announcing progress to the kernel too soon when an
announcement was requested via sys_clock_set_timeout() on a tick
boundary. Fix rounding to add a tick worth of cycles.

Fixes #42665

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
This commit is contained in:
Daniel DeGrasse 2022-02-10 14:22:51 -06:00 • committed by David Leach
commit 0694e47f97
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/timer/mcux_gpt_timer.c
View file

@ -192,7 +192,7 @@ void sys_clock_set_timeout(int32_t ticks, bool idle)
}
ticks = (ticks == K_TICKS_FOREVER) ? MAX_TICKS : ticks;
/* Clamp ticks */
ticks = CLAMP(ticks - 1, 0, (int32_t)MAX_TICKS);
ticks = CLAMP((ticks - 1), 0, (int32_t)MAX_TICKS);
key = k_spin_lock(&lock);
@ -220,6 +220,13 @@ void sys_clock_set_timeout(int32_t ticks, bool idle)
reload_value =
((reload_value + CYC_PER_TICK - 1) / CYC_PER_TICK) * CYC_PER_TICK;
reload_value -= unannounced_cycles;
if (reload_value == ticks * CYC_PER_TICK) {
/* We are on a tick boundary. Since we subtracted from
* 'ticks' earlier, we need to add one tick worth of
* cycles to announce to the kernel at the right time.
*/
reload_value += CYC_PER_TICK;
}
/* Clamp reload value */
reload_value = CLAMP(reload_value, MIN_DELAY, MAX_CYCLES);
}