From 04e38ae176d8aab88c6b41b81959762a3a2ca573 Mon Sep 17 00:00:00 2001 From: Emil Gydesen Date: Wed, 22 May 2024 13:03:33 +0200 Subject: [PATCH] samples: Bluetooth: Fix incorrect comments about adv sets Several places we simply had /* Create a non-connectable non-scannable advertising set */ regardless of the type of advertising it was. Modified the comment to omit the scannable part and corrected the connectable part. Signed-off-by: Emil Gydesen --- samples/bluetooth/broadcast_audio_sink/src/main.c | 2 +- samples/bluetooth/broadcast_audio_source/src/main.c | 2 +- .../bluetooth/broadcaster_multiple/src/broadcaster_multiple.c | 2 +- samples/bluetooth/extended_adv/advertiser/src/main.c | 2 +- samples/bluetooth/hap_ha/src/main.c | 2 +- samples/bluetooth/iso_broadcast/src/main.c | 2 +- samples/bluetooth/iso_broadcast_benchmark/src/broadcaster.c | 2 +- samples/bluetooth/periodic_adv/src/main.c | 2 +- samples/bluetooth/periodic_adv_conn/src/main.c | 2 +- samples/bluetooth/periodic_adv_rsp/src/main.c | 2 +- samples/bluetooth/public_broadcast_source/src/main.c | 2 +- samples/bluetooth/tmap_bms/src/cap_initiator.c | 2 +- samples/bluetooth/unicast_audio_server/src/main.c | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/samples/bluetooth/broadcast_audio_sink/src/main.c b/samples/bluetooth/broadcast_audio_sink/src/main.c index 860434d428a..38f9f546078 100644 --- a/samples/bluetooth/broadcast_audio_sink/src/main.c +++ b/samples/bluetooth/broadcast_audio_sink/src/main.c @@ -1393,7 +1393,7 @@ static int start_adv(void) }; int err; - /* Create a non-connectable non-scannable advertising set */ + /* Create a connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &ext_adv); if (err != 0) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/broadcast_audio_source/src/main.c b/samples/bluetooth/broadcast_audio_source/src/main.c index e6f2c85b8b4..dbaffb0c2ff 100644 --- a/samples/bluetooth/broadcast_audio_source/src/main.c +++ b/samples/bluetooth/broadcast_audio_source/src/main.c @@ -493,7 +493,7 @@ int main(void) struct bt_data per_ad; uint32_t broadcast_id; - /* Create a non-connectable non-scannable advertising set */ + /* Create a connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CUSTOM, NULL, &adv); if (err != 0) { printk("Unable to create extended advertising set: %d\n", diff --git a/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c b/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c index 8da6984ee55..f2e7127b406 100644 --- a/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c +++ b/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c @@ -88,7 +88,7 @@ int broadcaster_multiple(void) /* Use advertising set instance index as SID */ adv_param.sid = index; - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(&adv_param, NULL, &adv[index]); if (err) { printk("Failed to create advertising set %d (err %d)\n", diff --git a/samples/bluetooth/extended_adv/advertiser/src/main.c b/samples/bluetooth/extended_adv/advertiser/src/main.c index be51694fd1a..efb8dbc3e1f 100644 --- a/samples/bluetooth/extended_adv/advertiser/src/main.c +++ b/samples/bluetooth/extended_adv/advertiser/src/main.c @@ -102,7 +102,7 @@ int main(void) return err; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/hap_ha/src/main.c b/samples/bluetooth/hap_ha/src/main.c index 205feceb0b8..586ed600469 100644 --- a/samples/bluetooth/hap_ha/src/main.c +++ b/samples/bluetooth/hap_ha/src/main.c @@ -100,7 +100,7 @@ static void adv_work_handler(struct k_work *work) int err; if (ext_adv == NULL) { - /* Create a non-connectable non-scannable advertising set */ + /* Create a connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, &adv_cb, &ext_adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/iso_broadcast/src/main.c b/samples/bluetooth/iso_broadcast/src/main.c index e0ff7dd306e..85460d10fdd 100644 --- a/samples/bluetooth/iso_broadcast/src/main.c +++ b/samples/bluetooth/iso_broadcast/src/main.c @@ -105,7 +105,7 @@ int main(void) return 0; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, &adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/iso_broadcast_benchmark/src/broadcaster.c b/samples/bluetooth/iso_broadcast_benchmark/src/broadcaster.c index 1040f0cd214..94f334ff54d 100644 --- a/samples/bluetooth/iso_broadcast_benchmark/src/broadcaster.c +++ b/samples/bluetooth/iso_broadcast_benchmark/src/broadcaster.c @@ -617,7 +617,7 @@ static int create_big(struct bt_le_ext_adv **adv, struct bt_iso_big **big) { int err; - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ LOG_INF("Creating Extended Advertising set"); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv); if (err != 0) { diff --git a/samples/bluetooth/periodic_adv/src/main.c b/samples/bluetooth/periodic_adv/src/main.c index 9b584966ce7..a927c82e16c 100644 --- a/samples/bluetooth/periodic_adv/src/main.c +++ b/samples/bluetooth/periodic_adv/src/main.c @@ -30,7 +30,7 @@ int main(void) return 0; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, &adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/periodic_adv_conn/src/main.c b/samples/bluetooth/periodic_adv_conn/src/main.c index 63818ddbeea..1bfcc55977a 100644 --- a/samples/bluetooth/periodic_adv_conn/src/main.c +++ b/samples/bluetooth/periodic_adv_conn/src/main.c @@ -181,7 +181,7 @@ int main(void) return 0; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, &adv_cb, &pawr_adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/periodic_adv_rsp/src/main.c b/samples/bluetooth/periodic_adv_rsp/src/main.c index 6764b023a5a..b88c724a222 100644 --- a/samples/bluetooth/periodic_adv_rsp/src/main.c +++ b/samples/bluetooth/periodic_adv_rsp/src/main.c @@ -266,7 +266,7 @@ int main(void) return 0; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, &adv_cb, &pawr_adv); if (err) { printk("Failed to create advertising set (err %d)\n", err); diff --git a/samples/bluetooth/public_broadcast_source/src/main.c b/samples/bluetooth/public_broadcast_source/src/main.c index 5ffb94d785f..f4dab65bbb2 100644 --- a/samples/bluetooth/public_broadcast_source/src/main.c +++ b/samples/bluetooth/public_broadcast_source/src/main.c @@ -127,7 +127,7 @@ static int setup_extended_adv(struct bt_le_ext_adv **adv) { int err; - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv); if (err != 0) { printk("Unable to create extended advertising set: %d\n", err); diff --git a/samples/bluetooth/tmap_bms/src/cap_initiator.c b/samples/bluetooth/tmap_bms/src/cap_initiator.c index 2c0019e234c..3cce613dd98 100644 --- a/samples/bluetooth/tmap_bms/src/cap_initiator.c +++ b/samples/bluetooth/tmap_bms/src/cap_initiator.c @@ -115,7 +115,7 @@ static int setup_extended_adv(struct bt_le_ext_adv **adv) { int err; - /* Create a non-connectable non-scannable advertising set */ + /* Create a non-connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv); if (err != 0) { printk("Unable to create extended advertising set: %d\n", err); diff --git a/samples/bluetooth/unicast_audio_server/src/main.c b/samples/bluetooth/unicast_audio_server/src/main.c index db2a76fbab6..6a39afb6879 100644 --- a/samples/bluetooth/unicast_audio_server/src/main.c +++ b/samples/bluetooth/unicast_audio_server/src/main.c @@ -750,7 +750,7 @@ int main(void) return 0; } - /* Create a non-connectable non-scannable advertising set */ + /* Create a connectable advertising set */ err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &adv); if (err) { printk("Failed to create advertising set (err %d)\n", err);