From 0492235d0dd84ad468acf84a4e3c97a88d98c700 Mon Sep 17 00:00:00 2001 From: Vinicius Miguel Date: Fri, 30 Aug 2024 16:28:12 +0200 Subject: [PATCH] scripts: ci: Fix crash when vendor list is malformed Also introduces friendly error message. Signed-off-by: Vinicius Miguel --- scripts/ci/check_compliance.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/ci/check_compliance.py b/scripts/ci/check_compliance.py index c8fb4bfd753..11887736877 100755 --- a/scripts/ci/check_compliance.py +++ b/scripts/ci/check_compliance.py @@ -264,8 +264,12 @@ class BoardYmlCheck(ComplianceTest): line = line.strip() if not line or line.startswith("#"): continue - vendor, _ = line.split("\t", 2) - vendor_prefixes.append(vendor) + try: + vendor, _ = line.split("\t", 2) + vendor_prefixes.append(vendor) + except ValueError: + self.error(f"Invalid line in vendor-prefixes.txt:\"{line}\".") + self.error("Did you forget the tab character?") path = Path(ZEPHYR_BASE) for file in path.glob("**/board.yml"):