michaelh/zephyr
1
0
Fork 0
Code Releases Activity

input: npcx_kbd: clear pending interrupts before reenabling detection

Browse source 
The driver right now re-enters polling mode a couple times after the
matrix has been detected as stable as the key interrupt is still pending
and fires again once detection is reenabled.

Clear pending WUI interrupts before reenabling key press detection to
avoid that.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2023-12-15 17:27:49 +00:00 • committed by Fabio Baltieri
commit 0442fe3bbf
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/input/input_npcx_kbd.c
View file

@ -57,8 +57,13 @@ static void npcx_kbd_ksi_isr(const struct device *dev, struct npcx_wui *wui)
static void npcx_kbd_set_detect_mode(const struct device *dev, bool enabled)
{
const struct npcx_kbd_config *const config = dev->config;
const struct input_kbd_matrix_common_config *common = &config->common;
if (enabled) {
for (int i = 0; i < common->row_size; i++) {
npcx_miwu_irq_get_and_clear_pending(&config->wui_maps[i]);
}
irq_enable(config->irq);
} else {
irq_disable(config->irq);