michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: espi: eSPI host DnX propagation fixes

Browse source 
Correct MEC15xx HAL value for DnX warn.
For consistency add automatic ack into the driver.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
This commit is contained in:
Jose Alberto Meza 2021-06-09 12:27:18 -07:00 • committed by Anas Nashif
commit 03ce67f153
1 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/espi/espi_mchp_xec.c
View file

@ -23,7 +23,7 @@
#define VW_MAX_GIRQS 2ul #define VW_MAX_GIRQS 2ul
/* Missing HAL value */ /* Missing HAL value */
#define MEC_ESPI_MSVW08_SRC1_VAL 5ul #define MEC_ESPI_MSVW08_SRC1_VAL BIT(5)
/* 200ms */ /* 200ms */
#define MAX_OOB_TIMEOUT 200ul #define MAX_OOB_TIMEOUT 200ul
@ -1114,6 +1114,10 @@ static void notify_host_warning(const struct device *dev,
espi_send_callbacks(&data->callbacks, dev, evt); espi_send_callbacks(&data->callbacks, dev, evt);
} else { } else {
k_busy_wait(ESPI_XEC_VWIRE_ACK_DELAY); k_busy_wait(ESPI_XEC_VWIRE_ACK_DELAY);
/* Some flows are dependent on awareness of client's driver
* about these warnings in such cases these automatic response
* should not be enabled.
*/
switch (signal) { switch (signal) {
case ESPI_VWIRE_SIGNAL_HOST_RST_WARN: case ESPI_VWIRE_SIGNAL_HOST_RST_WARN:
espi_xec_send_vwire(dev, espi_xec_send_vwire(dev,
@ -1128,6 +1132,10 @@ static void notify_host_warning(const struct device *dev,
espi_xec_send_vwire(dev, ESPI_VWIRE_SIGNAL_OOB_RST_ACK, espi_xec_send_vwire(dev, ESPI_VWIRE_SIGNAL_OOB_RST_ACK,
status); status);
break; break;
case ESPI_VWIRE_SIGNAL_DNX_WARN:
espi_xec_send_vwire(dev, ESPI_VWIRE_SIGNAL_DNX_ACK,
status);
break;
default: default:
break; break;
} }
@ -1338,7 +1346,7 @@ static void espi_xec_vw_isr(const struct device *dev)
#if DT_INST_PROP_HAS_IDX(0, vw_girqs, 1) #if DT_INST_PROP_HAS_IDX(0, vw_girqs, 1)
static void vw_sus_dnx_warn_isr(const struct device *dev) static void vw_sus_dnx_warn_isr(const struct device *dev)
{ {
notify_system_state(dev, ESPI_VWIRE_SIGNAL_DNX_WARN); notify_host_warning(dev, ESPI_VWIRE_SIGNAL_DNX_WARN);
} }
const struct espi_isr m2s_vwires_ext_isr[] = { const struct espi_isr m2s_vwires_ext_isr[] = {
@ -1354,7 +1362,7 @@ static void espi_xec_vw_ext_isr(const struct device *dev)
MCHP_GIRQ_SRC(config->vw_girq_ids[1]) = girq_result; MCHP_GIRQ_SRC(config->vw_girq_ids[1]) = girq_result;
for (int i = 0; i < ARRAY_SIZE(m2s_vwires_ext_isr); i++) { for (int i = 0; i < ARRAY_SIZE(m2s_vwires_ext_isr); i++) {
struct espi_isr entry = m2s_vwires_isr[i]; struct espi_isr entry = m2s_vwires_ext_isr[i];
if (girq_result & entry.girq_bit) { if (girq_result & entry.girq_bit) {
if (entry.the_isr != NULL) { if (entry.the_isr != NULL) {