michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: ATT: Fix error handling on prepare write response

Browse source 
Don't generate error response for invalid offset or invalid
attribute value during queued write requests.
According to BT SIG specification such response needs to be done when
execute write request is performed.

Change-Id: If480228dc98f5713891b45b3f5ca31990cf5c633
Signed-off-by: Arkadiusz Lichwa <arkadiusz.lichwa@tieto.com>
This commit is contained in:
Arkadiusz Lichwa 2015-09-23 09:58:46 +02:00 • committed by Anas Nashif
commit 0394ec6730
1 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
net/bluetooth/att.c
View file

@ -1077,8 +1077,20 @@ static uint8_t att_write_rsp(struct bt_conn *conn, uint8_t op, uint8_t rsp,
bt_gatt_foreach_attr(handle, handle, write_cb, &data);
/* In case of error discard data and respond with an error */
if (data.err) {
/* Don't send error response when user attribute write handler
* returns invalid offset or invalid attribute value length.
* Such response needs to be sent when execute write request
* is received.
* Refer to BT SIG 4.2 [Vol 3, Part F, 3.4.6.1] page 504
*/
if (data.op == BT_ATT_OP_PREPARE_WRITE_REQ &&
(data.err == BT_ATT_ERR_INVALID_OFFSET ||
data.err == BT_ATT_ERR_INVALID_ATTRIBUTE_LEN)) {
goto done;
}
/* In case of error discard data and respond with an error */
if (rsp) {
net_buf_unref(data.buf);
/* Respond here since handle is set */
@ -1087,6 +1099,7 @@ static uint8_t att_write_rsp(struct bt_conn *conn, uint8_t op, uint8_t rsp,
return 0;
}
done:
if (data.buf) {
/* Add prepare write response */
if (rsp == BT_ATT_OP_PREPARE_WRITE_RSP) {