michaelh/zephyr
1
0
Fork 0
Code Releases Activity

subsys: fcb: Check for mutex lock failure when walking FCB

Browse source 
Coverity-CID: 182195
Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2018-02-16 16:52:16 -08:00 • committed by Anas Nashif
commit 02dc6eb960
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
subsys/fs/fcb/fcb_walk.c
View file

@ -23,7 +23,7 @@ fcb_walk(struct fcb *fcb, struct flash_sector *sector, fcb_walk_cb cb,
entry_ctx.loc.fe_elem_off = 0; entry_ctx.loc.fe_elem_off = 0;
rc = k_mutex_lock(&fcb->f_mtx, K_FOREVER); rc = k_mutex_lock(&fcb->f_mtx, K_FOREVER);
if (rc) { if (rc < 0) {
return FCB_ERR_ARGS; return FCB_ERR_ARGS;
} }
while ((rc = fcb_getnext_nolock(fcb, &entry_ctx.loc)) != while ((rc = fcb_getnext_nolock(fcb, &entry_ctx.loc)) !=
@ -39,7 +39,10 @@ fcb_walk(struct fcb *fcb, struct flash_sector *sector, fcb_walk_cb cb,
if (rc) { if (rc) {
return rc; return rc;
} }
k_mutex_lock(&fcb->f_mtx, K_FOREVER); rc = k_mutex_lock(&fcb->f_mtx, K_FOREVER);
if (rc < 0) {
return FCB_ERR_ARGS;
}
} }
k_mutex_unlock(&fcb->f_mtx); k_mutex_unlock(&fcb->f_mtx);
return 0; return 0;