michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: ethernet: Check return value for start/stop

Browse source 
The L2 networking layer checks for return value from enable, but
Ethernet is not checking and always returns 0, so, relay the return
value from the Ethernet driver to networking stack.

This fixes the issue of interface start failing but interface still
being up.

Signed-off-by: Krishna T <krishna.t@nordicsemi.no>
This commit is contained in:
Krishna T 2023-01-12 01:42:28 +05:30 • committed by Carles Cufí
commit 02ab878704
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
subsys/net/l2/ethernet/ethernet.c
View file

@ -732,6 +732,7 @@ error:
static inline int ethernet_enable(struct net_if *iface, bool state)
{
int ret = 0;
const struct ethernet_api *eth =
net_if_get_device(iface)->api;
@ -743,15 +744,15 @@ static inline int ethernet_enable(struct net_if *iface, bool state)
net_arp_clear_cache(iface);
if (eth->stop) {
eth->stop(net_if_get_device(iface));
ret = eth->stop(net_if_get_device(iface));
}
} else {
if (eth->start) {
eth->start(net_if_get_device(iface));
ret = eth->start(net_if_get_device(iface));
}
}
return 0;
return ret;
}
enum net_l2_flags ethernet_flags(struct net_if *iface)