michaelh/zephyr
1
0
Fork 0
Code Releases Activity

interrupt_controller: ioapic_intr: revert CPU target change

Browse source 
Commit 5a9a33b0cf changes interrupt
destination in an attempt to broadcast interrupts. However, this
change causes interrupts to stop working on the UP Squared board
in non-SMP configuration. According to QEMU source code,
physical destination address 0xFF000000 is a special case where
it broadcasts the interrupts. However, none of the IOAPIC
documentation (that I can find) describes this behavior. So,
revert that commit.

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This commit is contained in:
Daniel Leung 2019-11-05 21:31:39 -08:00 • committed by David Leach
commit 005aff7743
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/interrupt_controller/ioapic_intr.c
View file

@ -117,7 +117,7 @@ int _ioapic_init(struct device *unused)
IOAPIC_PHYSICAL | 0 /* dummy vector */;
for (ix = 0; ix < CONFIG_IOAPIC_NUM_RTES; ix++) {
ioApicRedSetHi(ix, 0xFF000000);
ioApicRedSetHi(ix, 0);
ioApicRedSetLo(ix, rteValue);
}
#endif
@ -242,7 +242,7 @@ int ioapic_resume_from_suspend(struct device *port)
IOAPIC_FIXED | IOAPIC_INT_MASK |
IOAPIC_PHYSICAL | 0 ; /* dummy vector*/
}
ioApicRedSetHi(irq, 0xFF000000);
ioApicRedSetHi(irq, 0);
ioApicRedSetLo(irq, rteValue);
}
ioapic_device_power_state = DEVICE_PM_ACTIVE_STATE;
@ -295,7 +295,7 @@ void z_ioapic_irq_set(unsigned int irq, unsigned int vector, u32_t flags)
rteValue = IOAPIC_FIXED | IOAPIC_INT_MASK | IOAPIC_PHYSICAL |
(vector & IOAPIC_VEC_MASK) | flags;
ioApicRedSetHi(irq, 0xFF000000);
ioApicRedSetHi(irq, 0);
ioApicRedSetLo(irq, rteValue);
}