michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: ATT: Fix using of k_fifo_{put,get}

Browse source 
These functions don't work with buffers that do have fragments, instead
this replaces their usage with net_buf_{put,get}.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This commit is contained in:
Luiz Augusto von Dentz 2020-06-17 14:07:38 -07:00 • committed by Carles Cufí
commit 0028559860
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
subsys/bluetooth/host/att.c
View file

@ -445,7 +445,7 @@ static void bt_att_chan_send_rsp(struct bt_att_chan *chan, struct net_buf *buf,
err = bt_att_chan_send(chan, buf, cb); err = bt_att_chan_send(chan, buf, cb);
if (err) { if (err) {
/* Responses need to be sent back using the same channel */ /* Responses need to be sent back using the same channel */
k_fifo_put(&chan->tx_queue, buf); net_buf_put(&chan->tx_queue, buf);
} }
} }
@ -2500,12 +2500,12 @@ static void att_reset(struct bt_att *att)
#if CONFIG_BT_ATT_PREPARE_COUNT > 0 #if CONFIG_BT_ATT_PREPARE_COUNT > 0
/* Discard queued buffers */ /* Discard queued buffers */
while ((buf = k_fifo_get(&att->prep_queue, K_NO_WAIT))) { while ((buf = net_buf_get(&att->prep_queue, K_NO_WAIT))) {
net_buf_unref(buf); net_buf_unref(buf);
} }
#endif /* CONFIG_BT_ATT_PREPARE_COUNT > 0 */ #endif /* CONFIG_BT_ATT_PREPARE_COUNT > 0 */
while ((buf = k_fifo_get(&att->tx_queue, K_NO_WAIT))) { while ((buf = net_buf_get(&att->tx_queue, K_NO_WAIT))) {
net_buf_unref(buf); net_buf_unref(buf);
} }
@ -2539,7 +2539,7 @@ static void att_chan_detach(struct bt_att_chan *chan)
} }
/* Release pending buffers */ /* Release pending buffers */
while ((buf = k_fifo_get(&chan->tx_queue, K_NO_WAIT))) { while ((buf = net_buf_get(&chan->tx_queue, K_NO_WAIT))) {
net_buf_unref(buf); net_buf_unref(buf);
} }
@ -2970,7 +2970,7 @@ int bt_att_send(struct bt_conn *conn, struct net_buf *buf, bt_conn_tx_cb_t cb,
if (ret < 0) { if (ret < 0) {
/* Queue buffer to be send later */ /* Queue buffer to be send later */
BT_DBG("Queueing buffer %p", buf); BT_DBG("Queueing buffer %p", buf);
k_fifo_put(&att->tx_queue, buf); net_buf_put(&att->tx_queue, buf);
} }
return 0; return 0;