michaelh/zephyr
1
0
Fork 0
Code Releases Activity
zephyr/drivers/dma/dma_handlers.c

27 lines
723 B
C
Raw Permalink Normal View History

dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
/*
* Copyright (c) 2018 Intel Corporation
*
* SPDX-License-Identifier: Apache-2.0
*/
cleanup: include/: move dma.h to drivers/dma.h move dma.h to drivers/dma.h and create a shim for backward-compatibility. No functional changes to the headers. A warning in the shim can be controlled with CONFIG_COMPAT_INCLUDES. Related to #16539 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
2019-06-25 15:53:48 -04:00
#include <drivers/dma.h>
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
#include <syscall_handler.h>
/* Both of these APIs are assuming that the drive implementations are checking
* the validity of the channel ID and returning -errno if it's bogus
*/
zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/u\(8\|16\|32\|64\)_t/uint\1_t/g" git grep -l 's\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/s\(8\|16\|32\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
2020-05-27 11:26:57 -05:00
static inline int z_vrfy_dma_start(struct device *dev, uint32_t channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-04 15:57:57 -07:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, start));
all: Update reserved function names Update reserved function names starting with one underscore, replacing them as follows: '_k_' with 'z_' '_K_' with 'Z_' '_handler_' with 'z_handl_' '_Cstart' with 'z_cstart' '_Swap' with 'z_swap' This renaming is done on both global and those static function names in kernel/include and include/. Other static function names in kernel/ are renamed by removing the leading underscore. Other function names not starting with any prefix listed above are renamed starting with a 'z_' or 'Z_' prefix. Function names starting with two or three leading underscores are not automatcally renamed since these names will collide with the variants with two or three leading underscores. Various generator scripts have also been updated as well as perf, linker and usb files. These are drivers/serial/uart_handlers.c include/linker/kobject-text.ld kernel/include/syscall_handler.h scripts/gen_kobject_list.py scripts/gen_syscall_header.py Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>
2019-03-08 14:19:05 -07:00
return z_impl_dma_start((struct device *)dev, channel);
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
}
kernel: Port remaining syscalls to new API These calls are not accessible in CI test, nor do they get built on common platforms (in at least one case I found a typo which proved the code was truly unused). These changes are blind, so live in a separate commit. But the nature of the port is mechanical, all other syscalls in the system work fine, and any errors should be easily corrected. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
2019-08-13 11:34:34 -07:00
#include <syscalls/dma_start_mrsh.c>
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/u\(8\|16\|32\|64\)_t/uint\1_t/g" git grep -l 's\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/s\(8\|16\|32\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
2020-05-27 11:26:57 -05:00
static inline int z_vrfy_dma_stop(struct device *dev, uint32_t channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-04 15:57:57 -07:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, stop));
all: Update reserved function names Update reserved function names starting with one underscore, replacing them as follows: '_k_' with 'z_' '_K_' with 'Z_' '_handler_' with 'z_handl_' '_Cstart' with 'z_cstart' '_Swap' with 'z_swap' This renaming is done on both global and those static function names in kernel/include and include/. Other static function names in kernel/ are renamed by removing the leading underscore. Other function names not starting with any prefix listed above are renamed starting with a 'z_' or 'Z_' prefix. Function names starting with two or three leading underscores are not automatcally renamed since these names will collide with the variants with two or three leading underscores. Various generator scripts have also been updated as well as perf, linker and usb files. These are drivers/serial/uart_handlers.c include/linker/kobject-text.ld kernel/include/syscall_handler.h scripts/gen_kobject_list.py scripts/gen_syscall_header.py Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>
2019-03-08 14:19:05 -07:00
return z_impl_dma_stop((struct device *)dev, channel);
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-09 13:58:37 -08:00
}
kernel: Port remaining syscalls to new API These calls are not accessible in CI test, nor do they get built on common platforms (in at least one case I found a typo which proved the code was truly unused). These changes are blind, so live in a separate commit. But the nature of the port is mechanical, all other syscalls in the system work fine, and any errors should be easily corrected. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
2019-08-13 11:34:34 -07:00
#include <syscalls/dma_stop_mrsh.c>
Copy permalink