From ac4b4e3157c8742d25d23b01e2b268bd96950509 Mon Sep 17 00:00:00 2001 From: George Cushen Date: Wed, 13 Jan 2021 21:27:12 +0000 Subject: [PATCH] fix: style lint issues --- wowchemy/assets/scss/wowchemy/_card.scss | 8 +++---- wowchemy/assets/scss/wowchemy/_icons.scss | 2 -- wowchemy/assets/scss/wowchemy/_nav.scss | 2 ++ wowchemy/assets/scss/wowchemy/_root.scss | 4 +++- .../assets/scss/wowchemy/_shortcodes.scss | 1 + wowchemy/assets/scss/wowchemy/_widgets.scss | 21 ++++++++++++------- 6 files changed, 24 insertions(+), 14 deletions(-) diff --git a/wowchemy/assets/scss/wowchemy/_card.scss b/wowchemy/assets/scss/wowchemy/_card.scss index 47769155..9d4ac8c2 100644 --- a/wowchemy/assets/scss/wowchemy/_card.scss +++ b/wowchemy/assets/scss/wowchemy/_card.scss @@ -81,7 +81,7 @@ a.summary-link { margin-bottom: 0; } -.card .card-image.hover-overlay:before { +.card .card-image.hover-overlay::before { display: block; position: absolute; left: 0; @@ -94,7 +94,7 @@ a.summary-link { transition: all 0.2s ease-out; } -.card .card-image.hover-overlay:after { +.card .card-image.hover-overlay::after { display: block; position: absolute; left: 0; @@ -115,10 +115,10 @@ a.summary-link { box-shadow: 0 8px 16px 0 rgba(0, 0, 0, 0.2); } -.card:hover .card-image.hover-overlay:before { +.card:hover .card-image.hover-overlay::before { opacity: 0.8; } -.card:hover .card-image.hover-overlay:after { +.card:hover .card-image.hover-overlay::after { opacity: 0.6; } diff --git a/wowchemy/assets/scss/wowchemy/_icons.scss b/wowchemy/assets/scss/wowchemy/_icons.scss index 09d44e5f..6e762146 100644 --- a/wowchemy/assets/scss/wowchemy/_icons.scss +++ b/wowchemy/assets/scss/wowchemy/_icons.scss @@ -1,8 +1,6 @@ .svg-icon { display: inline-flex; align-self: center; -} -.svg-icon { height: 0.9em; width: 0.9em; } diff --git a/wowchemy/assets/scss/wowchemy/_nav.scss b/wowchemy/assets/scss/wowchemy/_nav.scss index 61ef14e5..2619cd9c 100644 --- a/wowchemy/assets/scss/wowchemy/_nav.scss +++ b/wowchemy/assets/scss/wowchemy/_nav.scss @@ -122,6 +122,7 @@ .theme-dropdown .dropdown-menu { /* Use style from uncollapsable dropdowns to prevent dropdown going off page. */ position: absolute; + /* Below style from .dropdown-menu-right to prevent dropdown going off page. */ right: 0; left: auto; @@ -130,6 +131,7 @@ // Allow user to horizontally scroll. // Commented out this feature as it causes dropdowns to appear within the menu bar. // TODO: re-enable in a way that doesn't break dropdowns. + /* .navbar .collapse { overflow-x: auto; diff --git a/wowchemy/assets/scss/wowchemy/_root.scss b/wowchemy/assets/scss/wowchemy/_root.scss index 157577e2..ce5579e9 100644 --- a/wowchemy/assets/scss/wowchemy/_root.scss +++ b/wowchemy/assets/scss/wowchemy/_root.scss @@ -245,7 +245,7 @@ figcaption { text-align: center; } -figcaption.numbered:before { +figcaption.numbered::before { font-weight: 700; text-transform: uppercase; content: attr(data-pre) counter(captions) attr(data-post); @@ -259,12 +259,14 @@ pre, code { font-family: $sta-font-mono, monospace; color: #c7254e; + /* Match bg of default highlight theme. */ background-color: rgb(248, 248, 248); } pre { margin: 0 0 1rem 0; + /* Match bg of default highlight theme. */ border-color: rgb(248, 248, 248); font-size: 0.7rem; diff --git a/wowchemy/assets/scss/wowchemy/_shortcodes.scss b/wowchemy/assets/scss/wowchemy/_shortcodes.scss index 8bb59e43..7f4aa34b 100644 --- a/wowchemy/assets/scss/wowchemy/_shortcodes.scss +++ b/wowchemy/assets/scss/wowchemy/_shortcodes.scss @@ -2,6 +2,7 @@ .cta-group { --button-group-margin: 0.75em; + display: flex; flex-wrap: wrap; list-style: none; diff --git a/wowchemy/assets/scss/wowchemy/_widgets.scss b/wowchemy/assets/scss/wowchemy/_widgets.scss index 4631d6ab..16765084 100644 --- a/wowchemy/assets/scss/wowchemy/_widgets.scss +++ b/wowchemy/assets/scss/wowchemy/_widgets.scss @@ -59,7 +59,9 @@ } /* Big underline style for links in dark sections */ + /* Disabled as it's an experimental style that requires CSS NOT Selector Level 4 (only in Safari) */ + /* .home-section.dark.big-underline a:not(.btn):not(.hero-cta-alt):not(.alert a) { text-decoration: none; @@ -73,7 +75,7 @@ right: 0; position: absolute; top: 100%; -}*/ +} */ // Fill padding of `.home-section` parent .home-section-bg { @@ -160,6 +162,7 @@ } /* Reset code highlighting style in Alerts when Alert is child of a `.dark` widget, but Alert should be light.` */ + /* But will this affect page which should have dark Alert? */ .dark .alert pre, .dark .alert code { @@ -191,7 +194,10 @@ .wg-hero.dark .hero-cta-alt, .wg-hero.dark .hero-note > * { color: #fff; - /*text-shadow: 1px 1px 4px rgba(0,0,0,0.5);*/ /* Uncomment to standout on complicated backgrounds. */ + + /* text-shadow: 1px 1px 4px rgba(0,0,0,0.5); */ + + /* Uncomment to standout on complicated backgrounds. */ } .wg-hero.dark a:not(.wg-hero .btn) { @@ -331,7 +337,7 @@ a.hero-cta-alt:hover { .portrait-title h2 { font-size: 1.75em; font-weight: 300; - color: #000000; + color: #000; margin: 20px 0 10px 0; } @@ -339,7 +345,7 @@ a.hero-cta-alt:hover { font-size: 1rem; font-weight: 300; color: rgba(0, 0, 0, 0.54); - margin: 0px 0 10px 0; + margin: 0 0 10px 0; } ul.network-icon { @@ -382,7 +388,7 @@ ul.ul-edu { ul.ul-edu li { position: relative; - padding: 0px 15px 4px 3px; + padding: 0 15px 4px 3px; } ul.ul-edu li .description p { @@ -433,7 +439,7 @@ ul.ul-edu li .description p.institution { // For a UL after P, remove the spacing between (P margin-bottom) without affecting any nested lists. .card .card-text p + ul { margin-top: -1rem; - margin-bottom: 0rem; + margin-bottom: 0; } .experience .m-2 .border, @@ -478,7 +484,8 @@ ul.ul-edu li .description p.institution { .projects-container { display: block; position: relative; - /*margin-top: 5rem;*/ + + /* margin-top: 5rem; */ overflow: hidden; }